Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SafeAutoCorrect: false to correct cop config #11542

Merged
merged 1 commit into from Feb 6, 2023

Conversation

eugeneius
Copy link
Contributor

#11211 added autocorrect for Lint/AssignmentInCondition, but marked Layout/AssignmentIndentation as unsafe for autocorrection.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

00ec9cb added autocorrect for
Lint/AssignmentInCondition, but marked Layout/AssignmentIndentation as
unsafe for autocorrection.
@bbatsov
Copy link
Collaborator

bbatsov commented Feb 6, 2023

Nice catch!

@bbatsov bbatsov merged commit fb8ce01 into rubocop:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants