Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect autocorrect for Style/AccessModifierDeclarations when multiple groupable access modifiers are defined #11530

Merged
merged 1 commit into from Feb 2, 2023

Conversation

ydah
Copy link
Member

@ydah ydah commented Feb 1, 2023

This PR is fix an incorrect autocorrect for Style/AccessModifierDeclarations when multiple groupable access modifiers are defined.

Code to reproduce

class Test
  private def foo; end
  private def bar; end
  def baz; end
end

Expected behavior

Automatically corrected as follows:

class Test
  def baz; end

  private

  def foo; end

  def bar; end
end

Actual behavior

Automatically corrected as follows:

class Test
  def baz; end
private

def bar; end # <--- The order is changing
private # <--- Duplicate

def foo; end # <--- The order is changing
end

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • [-] Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@ydah ydah force-pushed the fix-style-access-modifier-declarations branch 3 times, most recently from 376bf1f to a10c274 Compare February 1, 2023 17:05
…hen multiple groupable access modifiers are defined

This PR is fix an incorrect autocorrect for `Style/AccessModifierDeclarations` when multiple groupable access modifiers are defined.

## Code to reproduce

```ruby
class Test
  private def foo; end
  private def bar; end
  def baz; end
end
```

## Expected behavior

Automatically corrected as follows:

```ruby
class Test
  def baz; end

  private

  def foo; end

  def bar; end
end
```

## Actual behavior

Automatically corrected as follows:

```ruby
class Test
  def baz; end
private

def bar; end # <--- The order is changing
private # <--- Duplicate

def foo; end # <--- The order is changing
end
```
@ydah ydah force-pushed the fix-style-access-modifier-declarations branch from a10c274 to a3d4077 Compare February 2, 2023 06:38
@koic koic merged commit 3dce614 into rubocop:master Feb 2, 2023
@koic
Copy link
Member

koic commented Feb 2, 2023

Thanks!

@ydah ydah deleted the fix-style-access-modifier-declarations branch February 2, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants