Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Style/NestedTernaryOperator autocorrect for chained ternaries #11452

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FnControlOption
Copy link
Contributor

a ? b : c ? d : e should be autocorrected to:

if a
  b
elsif c
  d
else
  e
end

instead of:

if a
  b
else
  c ? d : e
end

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

`a ? b : c ? d : e` should be autocorrected to:

```
if a
  b
elsif c
  d
else
  e
end
```

instead of:

```
if a
  b
else
  c ? d : e
end
```
@koic
Copy link
Member

koic commented Jan 15, 2023

The cop name is "NestedTernaryOperator". I understand your point, but I wonder if it should target unnested ternary operators and autocorrect.

@FnControlOption
Copy link
Contributor Author

My thought was chained ternaries are just a subset of nested ternaries, no?

@koic
Copy link
Member

koic commented Jan 15, 2023

The current behavior is accepted corrected from nested ternary operators to ternary operators appearing only once. I'm wondering if this is intended behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants