Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Lint/UselessRuby2Keywords #11369

Merged

Conversation

koic
Copy link
Member

@koic koic commented Dec 31, 2022

This PR fixes the following error for Lint/UselessRuby2Keywords when using Proc#ruby2_keywords.

block = proc { |_, *args| klass.new(*args) }
block.ruby2_keywords if block.respond_to?(:ruby2_keywords
% bundle exec rubocop --only Lint/UselessRuby2Keywords -d
(snip)

An error occurred while Lint/UselessRuby2Keywords cop was inspecting /Users/koic/src/github.com/koic/rubocop-issues/ruby2_keywords/example.rb:2:0.
undefined method `def_type?' for nil:NilClass
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/lint/useless_ruby2_keywords.rb:80:in `on_send'

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes the following error for `Lint/UselessRuby2Keywords`
when using `Proc#ruby2_keywords`.

```ruby
block = proc { |_, *args| klass.new(*args) }
block.ruby2_keywords if block.respond_to?(:ruby2_keywords
```

```console
% bundle exec rubocop --only Lint/UselessRuby2Keywords -d
(snip)

An error occurred while Lint/UselessRuby2Keywords cop was inspecting /Users/koic/src/github.com/koic/rubocop-issues/ruby2_keywords/example.rb:2:0.
undefined method `def_type?' for nil:NilClass
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/lint/useless_ruby2_keywords.rb:80:in `on_send'
```
@bbatsov bbatsov merged commit 33bf9a0 into rubocop:master Jan 1, 2023
@bbatsov
Copy link
Collaborator

bbatsov commented Jan 1, 2023

Thanks!

@koic koic deleted the fix_an_error_for_lint_useless_ruby2_keywords branch January 1, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants