Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect autocorrect for Lint/RegexpAsCondition #11351

Conversation

koic
Copy link
Member

@koic koic commented Dec 30, 2022

This PR fixes the following incorrect autocorrect for Lint/RegexpAsCondition when using regexp literal with bang:

if !/foo/ =~ $_ =~ $_
end
% be rubocop --only Lint/RegexpAsCondition -a
(snip)

Offenses:

example.rb:1:5: W: [Corrected] Lint/RegexpAsCondition: Do not use regexp literal as a condition. The regexp literal matches $_ implicitly.
if !/foo/
    ^^^^^

1 file inspected, 1 offense detected, 1 offense corrected
% git diff .
diff --git a/regexp_as_condition/example.rb b/regexp_as_condition/example.rb
index 3cb37b3..6f925a3 100644
--- a/regexp_as_condition/example.rb
+++ b/regexp_as_condition/example.rb
@@ -1,2 +1,2 @@
-if !/foo/
+if !/foo/ =~ $_ =~ $_
 end

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes the following incorrect autocorrect for `Lint/RegexpAsCondition`
when using regexp literal with bang:

```ruby
if !/foo/ =~ $_ =~ $_
end
```

```console
% be rubocop --only Lint/RegexpAsCondition -a
(snip)

Offenses:

example.rb:1:5: W: [Corrected] Lint/RegexpAsCondition: Do not use regexp literal as a condition. The regexp literal matches $_ implicitly.
if !/foo/
    ^^^^^

1 file inspected, 1 offense detected, 1 offense corrected
```

```diff
% git diff .
diff --git a/regexp_as_condition/example.rb b/regexp_as_condition/example.rb
index 3cb37b3..6f925a3 100644
--- a/regexp_as_condition/example.rb
+++ b/regexp_as_condition/example.rb
@@ -1,2 +1,2 @@
-if !/foo/
+if !/foo/ =~ $_ =~ $_
 end
```
@bbatsov bbatsov merged commit 4360526 into rubocop:master Dec 31, 2022
@bbatsov
Copy link
Collaborator

bbatsov commented Dec 31, 2022

Thanks!

@koic koic deleted the fix_an_incorrect_autocorrect_for_lint_regexp_as_condition branch December 31, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants