Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8827] Change Style/FormatStringToken style to template internally #11349

Conversation

pirj
Copy link
Member

@pirj pirj commented Dec 29, 2022

Related: #8827

Extracted from #10723


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • [-] Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • [-] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic
Copy link
Member

koic commented Dec 30, 2022

I'm going close this PR. Because the default change has not yet been finalized and different from the default doesn't look better.

@koic koic closed this Dec 30, 2022
@pirj pirj changed the title [#8227] Change Style/FormatStringToken style to template internally [#8827] Change Style/FormatStringToken style to template internally Dec 30, 2022
@pirj
Copy link
Member Author

pirj commented Dec 30, 2022

the default change has not yet been finalized

@koic May I kindly ask you to elaborate on "finalized"?

As previously discussed:

I don't mind changing this for RuboCop itself (unless someone from https://github.com/orgs/rubocop/teams/rubocop-core objects)

And there were no objections to changing it for RuboCop itself.

I apologize for the possible confusion, I've mistakenly put the ticket as #8227, while it should have been #8827.

doesn't look better

When it comes to a point where subjective opinion, I we refer to the style guide.
The style guide recommends %<...> over %{...}, but this small research shows that the real-world usage is different.

The style guide's promise is:

A style guide that reflects real-world usage gets used, while a style guide that holds to an ideal that has been rejected by the people it is supposed to help risks not getting used at all - no matter how good it is.

Basing on this, I intend to propose a change to the Style Guide, and get back to this PR after. All for consistency across various Ruby codebases.

@pirj
Copy link
Member Author

pirj commented Jan 8, 2023

@koic ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants