Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Style/SelectByRegexp #11348

Merged
merged 1 commit into from Dec 30, 2022

Conversation

koic
Copy link
Member

@koic koic commented Dec 29, 2022

This PR fixes the following error for Style/SelectByRegexp when block body is empty:

array.select { }
% bundle exec rubocop --only Style/SelectByRegexp -d
(snip)

An error occurred while Style/SelectByRegexp cop was inspecting /Users/koic/src/github.com/koic/rubocop-issues/empty_body/example.rb:1:0.
undefined method `begin_type?' for nil:NilClass
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/select_by_regexp.rb:89:in `on_send'

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes the following error for `Style/SelectByRegexp`
when block body is empty:

```ruby
array.select { }
```

```console
% bundle exec rubocop --only Style/SelectByRegexp -d
(snip)

An error occurred while Style/SelectByRegexp cop was inspecting /Users/koic/src/github.com/koic/rubocop-issues/empty_body/example.rb:1:0.
undefined method `begin_type?' for nil:NilClass
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/select_by_regexp.rb:89:in `on_send'
```
@koic koic force-pushed the fix_error_for_style_select_by_regexp branch from 5e0b8ac to e24b0d0 Compare December 29, 2022 05:17
@koic koic merged commit 6066e2a into rubocop:master Dec 30, 2022
@koic koic deleted the fix_error_for_style_select_by_regexp branch December 30, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant