Support pattern matching for Lint/OutOfRangeRegexpRef cop
#11337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
k-tsj
reviewed
Feb 13, 2023
| pattern = pattern_node.node_parts[0] | ||
|
|
||
| case pattern.type | ||
| when :array_pattern, :match_alt |
There was a problem hiding this comment.
@fatkodima @bbatsov
I may be wrong, as I only glanced at it, but I don't think it supports hash pattern/find pattern/value pattern with the pin operator(^(expression)).
{a: 'foo'} => {a: /(.)/}
p $1
['foo'] => [*, /(.)/, *]
p $1
'foo' => ^(/(.)/)
p $1The last one may not need to be fixed since it is difficult to fully support and is not a practical code.
There was a problem hiding this comment.
Thanks for reporting. Indeed, this PR's implementation should be done in a simpler way - #11573
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10976.
Note: This is the first time I familiarized myself with the pattern matching in ruby, so be a little more careful when reviewing this PR.