Accept simple freezed constants in Layout/ClassStructure and correctly handle class methods
#11329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Thanks! |
koic
added a commit
to rubocop/rubocop-performance
that referenced
this pull request
Dec 25, 2022
koic
added a commit
to rubocop/rubocop-rails
that referenced
this pull request
Dec 25, 2022
koic
added a commit
to rubocop/rubocop-minitest
that referenced
this pull request
Dec 25, 2022
koic
added a commit
to rubocop/rubocop-ast
that referenced
this pull request
Dec 25, 2022
Follow up rubocop/rubocop#11329 ```console % bundle exec rake (snip) Offenses: lib/rubocop/ast/node_pattern.rb:105:7: C: [Correctable] Layout/ClassStructure: public_class_methods is supposed to appear before initializer. def self.descend(element, &block) ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lib/rubocop/ast/processed_source.rb:23:7: C: [Correctable] Layout/ClassStructure: constants is supposed to appear before public_class_methods. INVALID_LEVELS = %i[error fatal].freeze ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ tasks/changelog.rb:121:3: C: [Correctable] Layout/ClassStructure: public_class_methods is supposed to appear before initializer. def self.pending? ... ^^^^^^^^^^^^^^^^^ 162 files inspected, 3 offenses detected, 3 offenses autocorrectable ```
MarttiCheng
added a commit
to MarttiCheng/Rubocop-Performance
that referenced
this pull request
Sep 28, 2023
SerhiiMisiura
added a commit
to SerhiiMisiura/Rubocop-Performance
that referenced
this pull request
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 problems:
.freezeconstants are considered as "dynamic constants" and are ignored from the consideration. Changed that.This PR also fixes #8034.
As a follow up to this, I will extend this cop to be able to detect private constants and class methods, to avoid having disables like
rubocop/lib/rubocop/cop/base.rb
Lines 330 to 333 in 20b32e4
Layout/ClassStructurecurrently suggests, thats why# rubocop:disable).