Support autocorrection for percent literals in Style/ConcatArrayLiterals
#11328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| RUBY | ||
|
|
||
| expect_correction(<<~RUBY) | ||
| item.push(:item) |
There was a problem hiding this comment.
minor -- I find it confusing that this test file uses item for both the list and the item being inserted. list.push(:item) would make more sense
There was a problem hiding this comment.
Agreed, but this is how this is done for this entire spec file. Do not want to change the lines history and make diff bigger than is needed.
But if requested, will do with no problems..
There was a problem hiding this comment.
Feel free to add a second commit that changes this. I'd suggest using something like arr instead of item.
fatkodima
force-pushed
the
concat_array_literals-autocorrection
branch
from
de187ed
to
a129b2f
Compare
|
This looks good to me. Can you squash your commits into one? |
fatkodima
force-pushed
the
concat_array_literals-autocorrection
branch
from
a129b2f
to
62d38f5
Compare
|
Squashed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11325.
%W/%Iliterals with interpolations inside are skipped for autocorrection, because they are rare and could further complicate this cop's logic. Other cases are pretty common.