Make Style/ZeroLengthPredicate aware of array.length.zero?
#11327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes rubocop#11314. Follow rubocop#11314 (comment). This PR makes `Style/ZeroLengthPredicate` aware of `array.length.zero?`. I'm not sure if `array.any?` is better than `array.length.positive` as answered in rubocop#11314. But `array.length == 0` and `array.length.zero?` are equivalent, it should be possible to convert to `array.emtpy?` in the same way.
|
Nice improvement. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11314.
Follow #11314 (comment).
This PR makes
Style/ZeroLengthPredicateaware ofarray.length.zero?.I'm not sure if
array.any?is better thanarray.length.positiveas answered in #11314.But
array.length == 0andarray.length.zero?are equivalent, it should be possible to convert toarray.emtpy?in the same way.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.