Fix an error for Style/GuardClause when using lvar as an argument of raise in else branch
#11307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydah
force-pushed
the
fix/guard_clause
branch
from
e4a93de
to
f3299c2
Compare
koic
reviewed
Dec 20, 2022
koic
reviewed
Dec 20, 2022
ydah
force-pushed
the
fix/guard_clause
branch
from
f3299c2
to
7f3f3bb
Compare
koic
reviewed
Dec 20, 2022
ydah
force-pushed
the
fix/guard_clause
branch
2 times, most recently
from
2aa2db3
to
5f0e799
Compare
|
Thank you so much. I updated this PR. |
|
Can you take a look at this too? |
ydah
force-pushed
the
fix/guard_clause
branch
from
5f0e799
to
51406f2
Compare
koic
reviewed
Dec 20, 2022
…f raise in `else` branch Follow up: rubocop#11250 (comment)
ydah
force-pushed
the
fix/guard_clause
branch
from
51406f2
to
dc4a1eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up: #11250 (comment)
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.