Support inline visibility definition on checking visibility #11171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following patterns have not been supported by
RuboCop::Cop::VisibilityHelp#node_visibility
:I think it would be good to support them as well.
The background leading me to this change is as follows:
I am trying to create a Cop that inspects unrecommended visibility of some method definitions. I tried to use the
#node_visibility
for this implementation, but realized that this would not work as intended in this case if inline style visibility was used. There seemed to be no obvious reason not to support it, so I decided to create this Pull Request.(FYI: In fact, I'm trying to create a cop that detects some public methods in Rails controller that actually should be private.)
After making the changes, several tests began to fail, so I decided to improve those as well.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.