Add if to allowed names list for MethodParameterName
#11158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It makes sense to me.
Yeah, can you add a changelog entry? Because this change impacts users. |
okuramasafumi
force-pushed
the
add-if-to-allowed-parameter-name
branch
from
6813945
to
8f1aff5
Compare
koic
reviewed
Nov 6, 2022
CHANGELOG.md
Outdated
| @@ -11,6 +11,7 @@ | |||
| * [#11126](https://github.com/rubocop/rubocop/pull/11126): Have `Lint/RedundantRequireStatement` mark `set` as a redundant require in Ruby 3.2+. ([@drenmi][]) | |||
| * [#11001](https://github.com/rubocop/rubocop/pull/11001): Add option to raise cop errors `--raise-cop-error`. ([@wildmaples][]) | |||
| * [#10987](https://github.com/rubocop/rubocop/pull/10987): Opt-in cop compatibility in redundant directives. ([@tdeo][]) | |||
| * [#11158](https://github.com/rubocop/rubocop/pull/11158): Add `if` to allowed names list for MethodParameterName. ([@okuramasafumi][]) | |||
There was a problem hiding this comment.
Please add a changelog entry file instead of editing CHANGELOG.md directly:
- Added an entry (file) to the changelog folder named
{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.
e.g. e2c1298
In library development, we sometimes use `if` as a keyword argument. The meaning of `if` is clear enough so we can accept it as an allowed name.
okuramasafumi
force-pushed
the
add-if-to-allowed-parameter-name
branch
from
8f1aff5
to
9cc6719
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In library development, we sometimes use
ifas a keyword argument.The meaning of
ifis clear enough so we can accept it as an allowed name.I'm not sure if it deserves its own CHANGELOG entry, but please let me know if I should add it.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.