Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Style/OperatorMethodCall autocorrection when operators are chained #11156

Merged
merged 1 commit into from Nov 5, 2022

Conversation

gsamokovarov
Copy link
Contributor

Ran it in Dext and this little gem of a code...

receipt_total = receipt.total_amount.*(convert_rate).round(2)
receipt_vat = receipt.tax_amount.*(convert_rate).round(2)

got autocorrected to:

receipt_total = receipt.total_amount(*convert_rate.round(2))
receipt_vat = receipt.tax_amount(*convert_rate.round(2))

I expected:

receipt_total = (receipt.total_amount * convert_rate).round(2)
receipt_vat = (receipt.tax_amount * convert_rate).round(2)

The Style/OperatorMethodCall didn't autocorrect operator method calls in chaining properly so I made it so.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@gsamokovarov gsamokovarov changed the title Fix Style/OperatorMethodCall autocorrection when operators are chained Fix Style/OperatorMethodCall autocorrection when operators are chained Nov 5, 2022
Ran it in Dext and this little gem of a code...

```ruby
receipt_total = receipt.total_amount.*(convert_rate).round(2)
receipt_vat = receipt.tax_amount.*(convert_rate).round(2)
```

got autocorrected to:

```ruby
receipt_total = receipt.total_amount(*convert_rate.round(2))
receipt_vat = receipt.tax_amount(*convert_rate.round(2))
```

I expected:

```ruby
receipt_total = (receipt.total_amount * convert_rate).round(2)
receipt_vat = (receipt.tax_amount * convert_rate).round(2)
```

The `Style/OperatorMethodCall` didn't autocorrect operator method calls
in chaining properly so I made it so.
@koic koic merged commit d16a1f0 into rubocop:master Nov 5, 2022
@koic
Copy link
Member

koic commented Nov 5, 2022

Thanks!

@gsamokovarov gsamokovarov deleted the operator-method-chaining-call branch November 5, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants