Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Lint/RedundantRequireStatement mark set as a redundant require in Ruby 3.2+ #11126

Merged

Conversation

Drenmi
Copy link
Collaborator

@Drenmi Drenmi commented Oct 27, 2022

In Ruby 3.2, set will be included by default.

From the Ruby announcement:

Set is now available as a builtin class without the need for require "set". [Feature #16989] It is currently autoloaded via the Set constant or a call to Enumerable#to_set.

This PR updates Lint/RedundantRequireStatement to flag require "set" when configured to inspect Ruby 3.2 or higher.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@Drenmi Drenmi force-pushed the feature/add-set-to-redundant-require-statements branch from b571d55 to c3cc6bb Compare October 27, 2022 08:43
@bbatsov bbatsov merged commit 3087023 into rubocop:master Oct 27, 2022
@bbatsov
Copy link
Collaborator

bbatsov commented Oct 27, 2022

Finally! 🚀

@Drenmi Drenmi deleted the feature/add-set-to-redundant-require-statements branch October 27, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants