Report the count of files in the Worst and Offense Count formatters #11113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hosamaly
force-pushed
the
report-file-counts-in-worst-formatter
branch
from
267e532
to
47c0362
Compare
hosamaly
changed the title
bbatsov
reviewed
Oct 24, 2022
| output.puts '--' | ||
| output.puts "#{total_count} Total" | ||
| output.puts "#{total_count} Total offenses in #{file_count} offending files" |
There was a problem hiding this comment.
I think the word "offending" is redundant here, given the context.
There was a problem hiding this comment.
I had written it initially without "offending", but it felt a bit ambiguous: was this the total number of processed files, or the number of files with offenses?
I'm not worried too much, though, so I'm ok either way. What do you think?
There was a problem hiding this comment.
I think here it should be quiet clear from the context, so probably less is more. Even the word "offenses" is kind of redundant IMO.
There was a problem hiding this comment.
I updated it to show 3 Total in 2 files.
…ormal usage These specs called `file_finished` for one file only, even though the test sets up multiple files. The method is now called for each file.
hosamaly
force-pushed
the
report-file-counts-in-worst-formatter
branch
from
f516429
to
c0763f1
Compare
|
Thanks! |
koic
added a commit
that referenced
this pull request
Oct 28, 2022
Follow up #11113. This commit fies the following build error. ```console ==> Failures 1) RuboCop::CLI for a disabled cop reports no offense when enabled on part of a file Failure/Error: expect($stdout.string).to eq(<<~RESULT) -- 0 Total RESULT expected: "\n--\n0 Total\n\n" got: "\n--\n0 Total in 0 files\n\n" (compared using ==) Diff: @@ -1,4 +1,4 @@ -- -0 Total +0 Total in 0 files # ./spec/rubocop/cli_spec.rb:302:in `block (3 levels) in <top (required)>' # ./spec/support/cli_spec_behavior.rb:26:in `block (2 levels) in <top (required)>' ```
hosamaly
added a commit
to hosamaly/rubocop
that referenced
this pull request
Nov 3, 2022
Update the sample output for the Offense Count and the Worst Offenders formatters to match the changes in rubocop#11113.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report the count of files in the Worst and the Offence Counts formatters. Their output now looks like this:
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.