Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Style/RedundantStringEscape cop #11095

Merged

Commits on Oct 21, 2022

  1. Fix an error for Style/RedundantStringEscape cop

    This PR fixes the following error for `Style/RedundantStringEscape` cop
    when using `?\n` string character literal.
    
    ```console
    % cat example.rb
    ?\n
    
    % bundle exec rubocop --only Style/RedundantStringEscape -d
    (snip)
    
    An error occurred while Style/RedundantStringEscape cop was inspecting /Users/koic/src/github.com/koic/rubocop-issues/11090/example.rb:1:0.
    undefined method `source' for nil:NilClass
    
              delimiters = [node.loc.begin.source[-1], node.loc.end.source[0]]
                                                                   ^^^^^^^
    /Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/redundant_string_escape.rb:162:in `delimiter?'
    /Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/redundant_string_escape.rb:110:in `single_quoted?'
    /Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/redundant_string_escape.rb:103:in `interpolation_not_enabled?'
    /Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/redundant_string_escape.rb:85:in `allowed_escape?'
    /Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/redundant_string_escape.rb:51:in `block in on_str'
    ```
    
    Similar case to rubocop#11089, but not resolved by rubocop#11090.
    It also removes a bit of unnecessary implementation logic I found.
    koic committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    5583d05 View commit details
    Browse the repository at this point in the history