Add InternalAffairs/ExampleHeredocDelimiter cop
#11094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r7kamura
force-pushed
the
feature/example-heredoc-delimiter
branch
from
327b2cb
to
4709e85
Compare
koic
reviewed
Oct 21, 2022
| # | ||
| # @safety | ||
| # This cop is unsafe because the heredoc body may also contain a `RUBY` line, | ||
| # in which case this word cannot be used for the delimiter. |
There was a problem hiding this comment.
Since this is detectable, it should be able to be made safe. Can you add tests and adjust the implementation? An approach could be that this case is only detected and not auto-corrected.
There was a problem hiding this comment.
That's right. Looking at some existing codes, there are cases where we really want to use a RUBY line in heredoc body, so I decided not to make such a case an offense.
r7kamura
force-pushed
the
feature/example-heredoc-delimiter
branch
from
4709e85
to
7502a9e
Compare
|
Note: I'm going to merge this new |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to the following review comment, I have created a cop to consistently use
RUBYdelimiter for heredocs in cop tests.Performance/RedundantMatchwhen receiver is a Regexp literal rubocop-performance#297 (comment)cc: @koic
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.