Implement Lint/DuplicateMethods for object singleton class
#11055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Oct 9, 2022
| @@ -132,8 +132,18 @@ def message_for_dup(node, method_name) | |||
| current: source_location(node)) | |||
| end | |||
|
|
|||
| def found_sclass_method(node, name) | |||
There was a problem hiding this comment.
That's just my two cents. Can you move this found_sclass_method method definition between found_instance_method and found_method method definitions?
There was a problem hiding this comment.
Makes sense indeed, just did
|
Nice 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cop implementation for an object singleton class when opening
class << foohadn't been done, this implements the expected behavior in the pending tests.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.