[Fix #11040] Fix a false positive for Style/IfUnlessModifier
#11041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_a_false_positive_for_style_if_unless_modifier
branch
2 times, most recently
from
77b1c87
to
4b23c53
Compare
|
Seems to me this will still be broken if you have more complex logic like We should probably document this shortcoming with or without the proposed fix. |
|
@koic Seems we forgot about this PR. |
|
Sorry for delay. I will retake this in a little while. |
koic
force-pushed
the
fix_a_false_positive_for_style_if_unless_modifier
branch
from
4b23c53
to
b5498c3
Compare
|
I've updated this PR to resolve the oversight. |
Fixes rubocop#11040. This PR fixes a false positive for `Style/IfUnlessModifier` when `defined?`'s argument value is undefined.
koic
force-pushed
the
fix_a_false_positive_for_style_if_unless_modifier
branch
from
b5498c3
to
b3b478b
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11040.
This PR fixes a false positive for
Style/IfUnlessModifierwhendefined?'s argument value is undefined.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.