[Fix #11018] Add AllowedMethods and AllowedPatterns for Lint/NestedMethodDefinition
#11019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…int/NestedMethodDefinition` Fixes rubocop#11018 and rubocop#8860. This PR adds `AllowedMethods` and `AllowedPatterns` for `Lint/NestedMethodDefinition`. For example, `has_many`, `extending`, and other Rails APIs can be specified in RuboCop Rails config. `class_eval`, `instance_eval`, `module_eval`, `class_exec`, `instance_exec`, and `module_exec` leave hard-coded for core methods.
koic
force-pushed
the
add_allowed_methods_and_patterns_to_lint_nested_method_definition
branch
from
40e8dff
to
c0d25b6
Compare
|
Looks good. Thanks! |
koic
deleted the
add_allowed_methods_and_patterns_to_lint_nested_method_definition
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11018 and #8860.
This PR adds
AllowedMethodsandAllowedPatternsforLint/NestedMethodDefinition. For example,has_many,extending, and other Rails APIs can be specified in RuboCop Rails config.class_eval,instance_eval,module_eval,class_exec,instance_exec, andmodule_execleave hard-coded for core methods.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.