Fix a false positive for Style/Aliascop when alias in a method def
#11014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Oct 10, 2022
| def foo | ||
| alias_method :ala, :bala | ||
| end | ||
| RUBY |
There was a problem hiding this comment.
This looks strange and like a bug. I think NoMethodError is not expected. WDYT?
def foo
alias :to_string :to_s
end
foo
p 42.to_string # => "#<Integer:0x0000000000000055>"
def bar
alias_method :to_str, :to_s # => undefined method `alias_method' for main:Object (NoMethodError)
end
bar
p 42.to_strThere was a problem hiding this comment.
Indeed it is. I think it is better to fix it. Can we include the bug fix in this PR?
There was a problem hiding this comment.
Yes. This wrong behavior spec cannot be merged. Please update this PR.
|
@ydah Ping :-) |
The following cases will result in a NoMethodError if replaced with alias_method. Therefore, it is correct to regard it as a violation and not to replace it. ```ruby def foo alias :ala :bala end ```
ydah
force-pushed
the
enhance_doc_for_style_alias
branch
from
8a0e605
to
05029d9
Compare
ydah
changed the title
Style/AliascopStyle/Aliascop when alias in a method def
|
I updated this PR. Thank you so much. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following cases will result in a NoMethodError if replaced with alias_method.
Therefore, it is correct to regard it as a violation and not to replace it.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.