Make rubocop command aware of --server option from .rubocop and RUBOCOP_OPTS
#10997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UBOCOP_OPTS ## Summary This PR makes `rubocop` command aware of `--server` option from .rubocop and RUBOCOP_OPTS. If `RUBOCOP_OPTS` environment variable or `.rubocop` file contains `--server` option, `rubocop` command defaults to server mode. Other server options such as `stop-server`, `restart-server` specified on the command line will take precedence over them. This feature rides on the existing following feature. > Default command-line options are loaded from `.rubocop` and `RUBOCOP_OPTS` and > are combined with command-line options that are explicitly passed to `rubocop`. > Thus, the options have the following order of precedence (from highest to lowest): > > 1. Explicit command-line options > > 2. Options from RUBOCOP_OPTS environment variable > > 3. Options from .rubocop file. https://docs.rubocop.org/rubocop/1.36/usage/basic_usage.html#command-line-flags ## Other Information This PR adds .rubocop to .gitignore so that it used for RuboCop development is not mixed in git commit.
koic
force-pushed
the
make_rubocop_aware_of_server_option_from_file_and_env
branch
from
cc1b7f7
to
0172484
Compare
|
Looks good! |
koic
deleted the
make_rubocop_aware_of_server_option_from_file_and_env
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes
rubocopcommand aware of--serveroption from .rubocop and RUBOCOP_OPTS.If
RUBOCOP_OPTSenvironment variable or.rubocopfile contains--serveroption,rubocopcommand defaults to server mode. Other server options such asstop-server,restart-serverspecified on the command line will take precedence over them.This feature rides on the existing following feature.
https://docs.rubocop.org/rubocop/1.36/usage/basic_usage.html#command-line-flags
Other Information
This PR adds .rubocop to .gitignore so that it used for RuboCop development is not mixed in git commit.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.