Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10979] Fix a false positive for Style/RedundantParentheses #10980

Conversation

koic
Copy link
Member

@koic koic commented Aug 30, 2022

Fixes #10979.

This PR fixes a false positive for Style/RedundantParentheses when using parentheses in method call with pin operator.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…rentheses`

Fixes rubocop#10979.

This PR fixes a false positive for `Style/Style/RedundantParentheses`
when using parentheses in method call with pin operator.
@Tietew
Copy link
Contributor

Tietew commented Aug 30, 2022

Thanks for quick response! But I found that ^(pin (begin !{lvar ivar cvar gvar})) should be allowed.

@Tietew
Copy link
Contributor

Tietew commented Aug 30, 2022

For example:
foo in { bar: ^(1) } should be corrected to foo in { bar: 1 }.
foo in { bar: ^([1]) } should be corrected to foo in { bar: [1] }.
foo in { bar: ^([var]) } should be allowed.

@Tietew
Copy link
Contributor

Tietew commented Aug 30, 2022

Created new PR #10981

@koic
Copy link
Member Author

koic commented Aug 30, 2022

I will close this PR to take #10981.

@koic koic closed this Aug 30, 2022
@koic koic deleted the fix_a_false_positive_for_style_redundant_parentheses branch August 30, 2022 04:06
@koic koic changed the title [Fix #10979] Fix a false positive for Style/Style/RedundantParentheses [Fix #10979] Fix a false positive for Style/RedundantParentheses Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/RedundantParentheses false positive on a pin operator with expression
2 participants