[Fix rubocop#10969] Allow Lint/AmbiguousBlockAssociation `AllowedPa…
#10970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydah
reviewed
Aug 26, 2022
| @@ -81,7 +81,7 @@ def ambiguous_block_association?(send_node) | |||
| def allowed_method_pattern?(node) | |||
| node.assignment? || node.operator_method? || node.method?(:[]) || | |||
| allowed_method?(node.last_argument.method_name) || | |||
There was a problem hiding this comment.
How about the same problem with AllowedMethods?
There was a problem hiding this comment.
I think there it's fine to match on the name. Generally, it's a bit unclear which patterns would need to match on the entire send node's source.
There was a problem hiding this comment.
AllowedMethods and AllowedPatterns have different uses, so AllowedMethods seems fine.
|
I'm planning to cut a new release very soon, so it'd be nice to update this changelog entry and wrap up this bugfix in time for the next release. |
jcalvert
force-pushed
the
fix/10969
branch
2 times, most recently
from
fa047b5
to
525cff1
Compare
|
Please let me know if I should make any further changes. Thank you. 🙇 |
koic
reviewed
Aug 29, 2022
changelog/fix_allow_ambigious_block_association_to_match_source.md
Outdated
Show resolved
Hide resolved
…ttern` to match on `send_node.source` instead of `method_name`.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fix #10969] Allow
Lint/AmbiguousBlockAssociationAllowedPatternto match onsend_node.sourceinstead ofmethod_name[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.