[Fix #10958] Fix an infinite loop for Layout/SpaceInsideBlockBraces when multiline block
#10959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydah
force-pushed
the
fix_space_inside_block_braces
branch
from
c27c14e
to
1f060e7
Compare
koic
reviewed
Aug 25, 2022
ydah
force-pushed
the
fix_space_inside_block_braces
branch
from
1f060e7
to
34a1fcc
Compare
koic
reviewed
Aug 25, 2022
| @@ -0,0 +1 @@ | |||
| * [#10958](https://github.com/rubocop/rubocop/issues/10958): Fix an infinite loop for `Layout/SpaceInsideBlockBraces`. ([@ydah][]) | |||
There was a problem hiding this comment.
Can you add a more bit explanation about the context of this error?
ydah
force-pushed
the
fix_space_inside_block_braces
branch
from
34a1fcc
to
6455981
Compare
ydah
changed the title
Layout/SpaceInsideBlockBracesLayout/SpaceInsideBlockBraces when multiline block
koic
reviewed
Aug 25, 2022
changelog/fix_fix_an_infinite_loop_for_layout_space_inside_block_braces.md
Outdated
Show resolved
Hide resolved
ydah
force-pushed
the
fix_space_inside_block_braces
branch
from
5281966
to
7f3c2dc
Compare
koic
reviewed
Aug 25, 2022
| bar | ||
| ]} | ||
| ^{} Space inside } detected. | ||
| RUBY |
There was a problem hiding this comment.
Can you add expect_correction code? It looks like InfiniteCorrectionLoop error is not resolved.
There was a problem hiding this comment.
Ops, I added it. Thank you.
ydah
force-pushed
the
fix_space_inside_block_braces
branch
from
7f3c2dc
to
7ad6dd1
Compare
…Braces` when `EnforcedStyle` is `no_space` and using multiline block Fix: rubocop#10958
ydah
force-pushed
the
fix_space_inside_block_braces
branch
from
7ad6dd1
to
6a8b7e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #10958
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.