Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10893] Fix an error when running rubocop without bundle exec #10894

Merged
merged 1 commit into from Aug 9, 2022

Conversation

koic
Copy link
Member

@koic koic commented Aug 9, 2022

Fixes #10893.

This PR fixes an error when running rubocop without bundle exec.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the fix_an_error_for_no_bundle_exec branch from dc7f748 to 3fd1426 Compare August 9, 2022 10:16
…le exec`

Fixes rubocop#10893.

This PR fixes an error when running `rubocop` without `bundle exec`.
@koic koic force-pushed the fix_an_error_for_no_bundle_exec branch from 3fd1426 to 4b9f99b Compare August 9, 2022 10:24
@koic
Copy link
Member Author

koic commented Aug 9, 2022

@bbatsov This may be a critical issue for upgrades (1.34). It may be better to release a bugfix (1.34.1) release as soon as possible.
A separate reproduction test that excludes bundle exec may be possible, anyway I'm leaving a comment for now.

@dvandersluis
Copy link
Member

dvandersluis commented Aug 9, 2022

There’s another ::Kernel.require a few lines below, does that need to be changed too?

::Kernel.require(namespaced_target)

@koic
Copy link
Member Author

koic commented Aug 9, 2022

It concerns #10845 new feature. First of all, this PR focuses only on the compatibility part.

@bbatsov bbatsov merged commit a133796 into rubocop:master Aug 9, 2022
@bbatsov
Copy link
Collaborator

bbatsov commented Aug 9, 2022

I'll cut a new release right away.

I hope @r7kamura will also find some time to look deeper into the cause of the problem.

@koic koic deleted the fix_an_error_for_no_bundle_exec branch August 9, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't execute v1.34.0 with error "cannot load such file -- rubocop-rails"
3 participants