Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10890] Fix an error for Layout/BlockEndNewline when multi-lineblocks with lambda literals #10891

Closed
wants to merge 1 commit into from

Conversation

ydah
Copy link
Member

@ydah ydah commented Aug 9, 2022

Fix: #10890

Replace this text with a summary of the changes in your PR.
The more detailed you are, the better.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@ydah ydah force-pushed the fix/layout-block-end-new-line branch from 43ee368 to 56d86ec Compare August 9, 2022 00:27
@ydah ydah force-pushed the fix/layout-block-end-new-line branch from 56d86ec to c99e7d2 Compare August 9, 2022 00:29
@dvandersluis
Copy link
Member

Wait this was already fixed 😁 #10878.

@ydah
Copy link
Member Author

ydah commented Aug 9, 2022

Oh. It was good. I forgot to bring it up to date. Is the test code also redundant? If it looks good to add, I will send a PR for the test enhancement.

@dvandersluis
Copy link
Member

I didn’t add a test specifically for lambdas so you could if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout/BlockEndNewline cop errors with irregular bracing layout
2 participants