Do not fork off extra processes if only a single file needs inspection #10889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umentIndentation` Fixes rubocop#10830. This PR fixes an incorrect autocorrect for `Layout/FirstArgumentIndentation` when specifying `EnforcedStyle: with_fixed_indentation` of `Layout/ArgumentAlignment` and `EnforcedStyle: consistent` of `Layout/FirstArgumentIndentation` and enabling `Layout/FirstMethodArgumentLineBreak`.
Fixes rubocop#10843. This PR fix a false positive for `Style/HashExcept` when using `reject` and calling `include?` method with symbol array and second block value.
…line option Fix rubocop#10771. This PR makes server mode aware of `--cache-root` command line option. The logic for getting `--cache-root` from command line option is original to make the implementation lighter. Because the client of server mode should be lightweight. rubocop#10842 needs a different solution than `--cache-root` option. I'm working on it separately from solving this issue.
Previously the wording implied that between major versions the API won't change. But it's pretty clear from the surrounding wording and general semvar concept that the API _will_ change between major versions... it's only between minor/patch versions that it won't change.
This PR is fix an autocorrect for `Style/RedundantSort` with predicate operator
If you have a code like the following:
```ruby
[1, 2, 3]
.sort_by { |x| x.length }
.first || []
```
After autocorrection it will look like this:
```ruby
[1, 2, 3]
.sort_by { |x| x.length }
|| []
```
This is a syntax error.
```
Error: : eval:3: syntax error, unexpected '|', expecting end-of-input
|| []
^
(SyntaxError)
```
…d two env vars (rubocop#10852) Fixes rubocop#10842 and follow up rubocop#10849. This PR makes server mode aware of `CacheRootDirectory` config option value, `RUBOCOP_CACHE_ROOT`, and `XDG_CACHE_HOME` environment variables. `RuboCop::ConfigLoader` and `RuboCop::ResultCache` classes to get these values has many dependencies. So, it is not suitable for use in server mode where speed is required. This solution is to extract `ConfigFinder` class from `ConfigLoader` class and `CacheConfig` class from `ResultCache` class. This allows server mode to depend on lightweight `ConfigFinder` and `CacheConfig` classes.
Shared libraries often contain timestamps of when they were compiled and other non-stable data hence would often produce different hashes on different machines
Fixes rubocop#10864. This PR fixes a false positive for `Style/SymbolProc` when using `Hash#reject`. The same is true for `Haash#select`. ```ruby {foo: :bar}.reject { p _1 } # `_1` is `:foo` {foo: :bar}.select { p _1 } # `_1` is `:foo` {foo: :bar}.detect { p _1 } # `_1` is `[:foo, :bar]` {foo: :bar}.map { p _1 } # `_1` is `[:foo, :bar]` ``` It fixes `on_block` method because the same issue occurs in normal blocks. ```ruby {foo: :bar}.select {|item| item.nil? } #=> no erros. {foo: :bar}.select(&:nil?) #=> wrong number of arguments (given 1, expected 0) (ArgumentError) ``` `Style/SymbolProc` is already marked as unsafe, but it avoids avoidable issues.
…s configuration options.
…led but not loaded in .rubocop.yml
…hains correctly.
…hen there is a hash or an array at return location of method
…eprecated Fixes rubocop#10871 and utkarsh2102/rubocop-packaging#44. This PR restores `RuboCop::ConfigLoader.project_root` as deprecated. It fixes the following build error. ```console % cd path/to/github.com/utkarsh2102/rubocop-packaging % bundle update && bundle exec rake (snip) Failures: 1) RuboCop::Cop::Packaging::BundlerSetupInTests when `require bundler/setup` is used in a Rakefile does not register an offense Failure/Error: let(:project_root) { RuboCop::ConfigLoader.project_root } NoMethodError: undefined method `project_root' for RuboCop::ConfigLoader:Class # ./spec/rubocop/cop/packaging/bundler_setup_in_tests_spec.rb:6:in `block (2 levels) in <top (required)>' # ./spec/rubocop/cop/packaging/bundler_setup_in_tests_spec.rb:39:in `block (3 levels) in <top (required)>' # ./spec/rubocop/cop/packaging/bundler_setup_in_tests_spec.rb:43:in `block (3 levels) in <top (required)>' ``` I considered a soft deprecation, but decided to issue a warning as it is probably of limited use.
404 Page Not Found is returned when https://docs.rubocop.org/rubocop/cop_api_v1_changelog.html is accessed. https://docs.rubocop.org/rubocop/v1_upgrade_notes.html would be the intended URL.
…ating `.rubocop_todo.yml`
Create two files with the following code:
```ruby
def fooBar; end
```
Set the following in .rubocop.yml:
```yml
Style/MethodName:
IgnoredPatterns:
- pattern1
- pattern2
```
Run `rubocop --auto-gen-config`
Then duplicate configuration values are enumerated in `.rubocop_todo.yml` as follows:
```yml
# Offense count: 2
# Configuration parameters: EnforcedStyle, AllowedPatterns, IgnoredPatterns.
# SupportedStyles: snake_case, camelCase
# AllowedPatterns: pattern1, pattern2, pattern1, pattern2, pattern1, pattern2, pattern1, pattern2, pattern1, pattern2, pattern1, pattern2, pattern1, pattern2, pattern1, pattern2, pattern1, pattern2, pattern1, pattern2, pattern1, pattern2, pattern1, pattern2, pattern1, pattern2, pattern1, pattern2, pattern1, pattern2, pattern1, pattern2, pattern1, pattern2
Naming/MethodName:
Exclude:
- 'test1.rb'
- 'test2.rb'
```
… over `Style/RedundantParentheses`. `Style/TernaryParentheses` allows RuboCop to require ternary conditions are wrapped in parentheses, but this behaviour doesn't take effect when `Style/RedundantParentheses` is also enabled, in order to prevent an infinite loop. However, it makes more sense for `TernaryParentheses` to take priority here and have `RedudantParentheses` allow the parentheses instead of creating an infinite autocorrection loop. This change moves the infinite loop protection into `RedundantParentheses` instead.
…lVariable` conditional statement and block variable
- Resolves what seems to be an unintentional typo where `elif` (as a method call) is being use in place of the `elsif` keyword.
Follow up rubocop/rubocop-ast#230 and fixes rubocop#10552. This commit fixes a false positive for `Lint/OutOfRangeRegexpRef` when using fixed-encoding regopt.
…single file needs to be inspected
|
Sigh, only commit 39a942d contains the changes I made. The rest comes from rebasing where I think I did something wrong when adding this repo as a remote 🤔 EDIT: Also the one failing test in the CI doesn't seem to be related to my changes. |
|
I like this idea but you have to clean up the commits. It looks like you somehow got a merge of master in between your two commits a653a0e and 39a942d. You should be able to do a git checkout master
git pull master
# interactive rebase (it’ll open an editor with instructions)
git rebase master --interactive
# or, create a new branch and cherry pick
git checkout -b [branch name]
git cherry pick a653a0e
git cherry pick 39a942dNB: if you create a new branch you'll have to close this PR and open a new one. |
|
The proposed change looks good to me. Don't forget to add a changelog entry about it. |
|
I made #10903 to replace this PR, it contains only the relevant changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR makes it so that if there is only a single file to be inspected, we do not split off extra worker processes to do the work. This is because doing the work in a separate process can never be faster than doing it inline. I benchmarked this change on my dev machine (with 6 physical cores) and it saves 40-50 ms per run (only if only a single file is inspected of course, otherwise it will take as long as before).
I did not know what to update the test with, so I just made it expect the new text. Let me know if this should be different.
Before submitting the PR make sure the following are checked:
Commit message starts with[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.