Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10857] Add AllowedPatterns to Style/NumericLiterals. #10873

Merged

Conversation

dvandersluis
Copy link
Member

Allows additional allowed patterns to be specified for Style/NumericLiterals so that special patterns will not register offenses. The patterns are forced to be anchored (so \d{4}_\d{4} will only match exactly that, and not substrings), and this does not affect autocorrection, which will continue to add underscores between groups of 3 digits.

Fixes #10857.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@dvandersluis dvandersluis force-pushed the style/numeric-literals-allowed-patterns branch from a48c502 to 8968b87 Compare August 5, 2022 16:05
config/default.yml Outdated Show resolved Hide resolved
@dvandersluis dvandersluis force-pushed the style/numeric-literals-allowed-patterns branch from 8968b87 to 3a267fe Compare August 6, 2022 03:41
@koic koic merged commit abd1347 into rubocop:master Aug 6, 2022
@koic
Copy link
Member

koic commented Aug 6, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add list of exception patterns to Style/NumericLiterals
2 participants