Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10859] Fix Lint/Debugger to be able to handle method chains correctly #10869

Merged
merged 1 commit into from Aug 5, 2022

Conversation

dvandersluis
Copy link
Member

Lint/Debugger was not handling method chains properly, so this fixes it. It also removes the implicit Kernel prefix and makes it explicit in the configuration (it wasn't working as expected anyways).

Fixes #10859.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@Ivanov-Anton
Copy link

tried all is working properly ✅

@koic koic merged commit 7593ec8 into rubocop:master Aug 5, 2022
@koic
Copy link
Member

koic commented Aug 5, 2022

Thanks!

@dvandersluis dvandersluis deleted the lint/debugger-method-chains branch August 5, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add page.driver.pause as additional element for DebuggerMethods of Lint/Debugger rubocop
3 participants