[Fix #10846] Fix a false negative for Style/DoubleNegation when there is a hash or an array at return location of method.
#10855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobuyo
force-pushed
the
fix-false-positive-for-style-double-nagation-when-hash-or-array-at-return-loc
branch
2 times, most recently
from
1e669f9
to
d21d828
Compare
bbatsov
reviewed
Aug 4, 2022
| @@ -0,0 +1 @@ | |||
| * [#10846](https://github.com/rubocop/rubocop/issues/10846): Fix a false positive for `Style/DoubleNagation` when there is a hash or an array at return location of method. ([@nobuyo][]) | |||
|
Btw, it seems to me the fix addresses a false negative, not a false positive. |
nobuyo
force-pushed
the
fix-false-positive-for-style-double-nagation-when-hash-or-array-at-return-loc
branch
from
d21d828
to
634201d
Compare
nobuyo
changed the title
Style/DoubleNagation when there is a hash or an array at return location of method.Style/DoubleNegation when there is a hash or an array at return location of method.
…hen there is a hash or an array at return location of method
nobuyo
force-pushed
the
fix-false-positive-for-style-double-nagation-when-hash-or-array-at-return-loc
branch
from
634201d
to
ee1ff39
Compare
|
Oops, you're right. I've fixed the problems, thanks. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #10846.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.