[Fix #10771] Make server mode aware of --cache-root command line option
#10849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
make_server_mode_aware_of_command_line_option
branch
from
ce5bb93
to
c28e9c0
Compare
dvandersluis
reviewed
Aug 1, 2022
koic
force-pushed
the
make_server_mode_aware_of_command_line_option
branch
2 times, most recently
from
a0cf812
to
6e9ea10
Compare
…line option Fix rubocop#10771. This PR makes server mode aware of `--cache-root` command line option. The logic for getting `--cache-root` from command line option is original to make the implementation lighter. Because the client of server mode should be lightweight. rubocop#10842 needs a different solution than `--cache-root` option. I'm working on it separately from solving this issue.
koic
force-pushed
the
make_server_mode_aware_of_command_line_option
branch
from
6e9ea10
to
9ec766e
Compare
|
Looks good to me. Thanks! |
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
Aug 3, 2022
…d two env vars Fixes rubocop#10842 and follow up rubocop#10849. This PR makes server mode aware of `CacheRootDirectory` config option value, `RUBOCOP_CACHE_ROOT`, and `XDG_CACHE_HOME` environment variables. `RuboCop::ConfigLoader` and `RuboCop::ResultCache` classes to get these values has many dependencies. So, it is not suitable for use in server mode where speed is required. This solution is to extract `ConfigPathFinder` class from `ConfigLoader` class and `CacheRoot` class from `ResultCache` class. This allows server mode to depend on lightweight `ConfigPathFinder` and `CacheRoot` classes.
bbatsov
pushed a commit
that referenced
this pull request
Aug 3, 2022
…nv vars (#10852) Fixes #10842 and follow up #10849. This PR makes server mode aware of `CacheRootDirectory` config option value, `RUBOCOP_CACHE_ROOT`, and `XDG_CACHE_HOME` environment variables. `RuboCop::ConfigLoader` and `RuboCop::ResultCache` classes to get these values has many dependencies. So, it is not suitable for use in server mode where speed is required. This solution is to extract `ConfigFinder` class from `ConfigLoader` class and `CacheConfig` class from `ResultCache` class. This allows server mode to depend on lightweight `ConfigFinder` and `CacheConfig` classes.
WJWH
pushed a commit
to WJWH/rubocop
that referenced
this pull request
Aug 8, 2022
…d two env vars (rubocop#10852) Fixes rubocop#10842 and follow up rubocop#10849. This PR makes server mode aware of `CacheRootDirectory` config option value, `RUBOCOP_CACHE_ROOT`, and `XDG_CACHE_HOME` environment variables. `RuboCop::ConfigLoader` and `RuboCop::ResultCache` classes to get these values has many dependencies. So, it is not suitable for use in server mode where speed is required. This solution is to extract `ConfigFinder` class from `ConfigLoader` class and `CacheConfig` class from `ResultCache` class. This allows server mode to depend on lightweight `ConfigFinder` and `CacheConfig` classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10771.
This PR makes server mode aware of
--cache-rootcommand line option.The logic for getting
--cache-rootfrom command line option is original to make the implementation lighter. Because the client of server mode should be lightweight.#10842 needs a different solution than
--cache-rootoption. I'm working on it separately from solving this issue.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.