[Fix #10825] Fix an incorrect autocorrect for Style/ClassAndModuleChildren

changelog/fix_an_incorrect_autocorrect_for_style_class_and_module_children.md

@@ -0,0 +1 @@
+* [#10825](https://github.com/rubocop/rubocop/issues/10825): Fix an incorrect autocorrect for `Style/ClassAndModuleChildren` when using nested one-liner class. ([@koic][])

lib/rubocop/cop/style/class_and_module_children.rb

@@ -117,10 +117,10 @@ def compact_identifier_name(node)
         end
 
         def remove_end(corrector, body)
-          range = range_between(
-            body.loc.end.begin_pos - leading_spaces(body).size,
-            body.loc.end.end_pos + 1
-          )
+          remove_begin_pos = body.loc.end.begin_pos - leading_spaces(body).size
+          adjustment = processed_source.raw_source[remove_begin_pos] == ';' ? 0 : 1
+          range = range_between(remove_begin_pos, body.loc.end.end_pos + adjustment)
+
           corrector.remove(range)
         end
 

spec/rubocop/cop/style/class_and_module_children_spec.rb

@@ -367,6 +367,20 @@ class BazModule
       RUBY
     end
 
+    it 'registers a offense for classes with nested one-liner children' do
+      expect_offense(<<~RUBY)
+        class FooClass
+              ^^^^^^^^ Use compact module/class definition instead of nested style.
+          class BarClass; end
+        end
+      RUBY
+
+      expect_correction(<<~RUBY)
+        class FooClass::BarClass
+        end
+      RUBY
+    end
+
     it 'accepts class/module with single method' do
       expect_no_offenses(<<~RUBY)
         class FooClass