[Fix rubocop#10813] Fix recursive deletion to suppression in Lint/NonAtomicFileOperation
#10818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Jul 15, 2022
ydah
force-pushed
the
fix_non_atomic_file_operation_for_recursive_deletion
branch
2 times, most recently
from
cdcc5d1
to
05c1426
Compare
|
Thank you so much. I updated this PR. |
koic
reviewed
Jul 20, 2022
…nAtomicFileOperation` Fixes: rubocop#10813 This PR is suppress offense in case of recursive deletion in `Lint/NonAtomicFileOperation`.
ydah
force-pushed
the
fix_non_atomic_file_operation_for_recursive_deletion
branch
from
05c1426
to
0b11d6d
Compare
bbatsov
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10813
This PR is suppress offense in case of
recursive deletion in
Lint/NonAtomicFileOperation.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.