Use RuboCop::AST::Token#regexp_dots?
#10803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
require_rubocop_ast_1_9
branch
from
41b18c9
to
44b6a90
Compare
koic
changed the title
RuboCop::AST::Token#regexp_dot?RuboCop::AST::Token#regexp_dots?
koic
force-pushed
the
require_rubocop_ast_1_9
branch
2 times, most recently
from
df87995
to
6c85e14
Compare
Follow up rubocop/rubocop-ast#235. This PR uses `RuboCop::AST::Token#regexp_dots?` instead of a custom logic. Also, `range_nodes` is only needed for autocorrection, so it's not needed most of the time. Therefore, the timing to calculate `range_nodes` is adjusted from `on_new_investigation` to memoization in the autocorrection logic by this PR.
koic
force-pushed
the
require_rubocop_ast_1_9
branch
from
6c85e14
to
819a677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up rubocop/rubocop-ast#235.
This PR uses
RuboCop::AST::Token#regexp_dots?instead of a custom logic.Also,
range_nodesis only needed for autocorrection, so it's not needed most of the time.Therefore, the timing to calculate
range_nodesis adjusted fromon_new_investigationto memoization in the autocorrection logic by this PR.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.