[Fix #10786] Fix a false positive for Lint/NonAtomicFileOperation

changelog/fix_a_false_positive_for_lint_non_atomic_file_operation.md

@@ -0,0 +1 @@
+* [#10786](https://github.com/rubocop/rubocop/issues/10786): Fix a false positive for `Lint/NonAtomicFileOperation` when using complex conditional. ([@koic][])

lib/rubocop/cop/lint/non_atomic_file_operation.rb

@@ -71,18 +71,22 @@ class NonAtomicFileOperation < Base
         PATTERN
 
         def on_send(node)
-          return unless node.parent&.if_type?
-          return if node.parent.else_branch
+          return unless (parent = node.parent) && parent.if_type?
+          return if allowable_use_with_if?(parent)
           return if explicit_not_force?(node)
-          return unless (exist_node = send_exist_node(node.parent).first)
+          return unless (exist_node = send_exist_node(parent).first)
           return unless exist_node.first_argument == node.first_argument
 
-          offense(node, exist_node)
+          register_offense(node, exist_node)
         end
 
         private
 
-        def offense(node, exist_node)
+        def allowable_use_with_if?(if_node)
+          if_node.condition.and_type? || if_node.condition.or_type? || if_node.else_branch
+        end
+
+        def register_offense(node, exist_node)
           range = range_between(node.parent.loc.keyword.begin_pos,
                                 exist_node.loc.expression.end_pos)
 

spec/rubocop/cop/lint/non_atomic_file_operation_spec.rb

@@ -183,4 +183,20 @@
       end
     RUBY
   end
+
+  it 'does not register an offense when using complex conditional with `&&`' do
+    expect_no_offenses(<<~RUBY)
+      if FileTest.exist?(path) && File.stat(path).socket?
+        FileUtils.mkdir(path)
+      end
+    RUBY
+  end
+
+  it 'does not register an offense when using complex conditional with `||`' do
+    expect_no_offenses(<<~RUBY)
+      if FileTest.exist?(path) || condition
+        FileUtils.mkdir(path)
+      end
+    RUBY
+  end
 end