Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10763] Fix a false positive for Layout/LineContinuationSpacing #10765

Conversation

koic
Copy link
Member

@koic koic commented Jun 28, 2022

Fixes #10763.

This PR fixes a false positive for Layout/LineContinuationSpacing when using continuation keyword \ after __END__.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…Spacing`

Fixes rubocop#10763.

This PR fixes a false positive for `Layout/LineContinuationSpacing`
when using continuation keyword `\` after `__END__`.
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 29, 2022

Thanks for tackling this! I guess at some point we should make sure no cops process anything in the data section. I keep forgetting this exists. :-)

@bbatsov bbatsov merged commit 5024054 into rubocop:master Jun 29, 2022
@koic koic deleted the fix_a_false_positive_for_layout_line_continuation_spacing branch June 29, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout/LineContinuationSpacing applies to non-Ruby source (DATA section)
2 participants