Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10760] Fix a false positive for Lint/NonAtomicFileOperation #10761

Conversation

koic
Copy link
Member

@koic koic commented Jun 28, 2022

Fixes #10760.

This PR fixes a false positive for Lint/NonAtomicFileOperation when using FileTest.exist? with if condition that has else branch.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…tion`

Fixes rubocop#10760.

This PR fixes a false positive for `Lint/NonAtomicFileOperation` when
using `FileTest.exist?` with `if` condition that has `else` branch.
@ydah
Copy link
Member

ydah commented Jun 28, 2022

Thank you so much!
I also checked the following similar false positive test case and it was resolved. Looks good to me.

if FileTest.exist?(path)
  do_something
elsif foo
  FileUtils.makedirs(path)
end

unless FileTest.exist?
  FileUtils.makedirs(path)
else
  do_something
end

@bbatsov bbatsov merged commit 27b0882 into rubocop:master Jun 28, 2022
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 28, 2022

Looks good. Thanks!

@koic koic deleted the fix_a_false_positive_for_non_atomic_file_operation branch June 28, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint/NonAtomicFileOperation create broken code (else without if)
3 participants