[Fix #10751] Fix autocorrect for Layout/FirstHashElementIndentation #10759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-miyake
force-pushed
the
fix_layout_first_hash_element_indentation
branch
from
a399fc1
to
cf91d1f
Compare
…ation Fixes rubocop#10751 `Layout/FirstHashElementIndentation` should allow a hash where the content of the first pair is indented relative to the base column specified with configured cop style, and the second pair begins on the same line with the right brace of the first pair; because those two keys won't be aligned with each other by `Layout/HashAlignment`, not like the case of rubocop#10689. With no parenthesis ```ruby post :create, params: { foo: { bar: 'Baz' } }, as: :json ``` With the parenthesis and `special_inside_parentheses` style ```ruby post(:create, params: { foo: { bar: 'Baz' } }, as: :json) ``` With the parenthesis and `consistent` style ```ruby post(:create, params: { foo: { bar: 'Baz' } }, as: :json) ```
j-miyake
force-pushed
the
fix_layout_first_hash_element_indentation
branch
from
cf91d1f
to
9ca3076
Compare
|
Well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10751
Layout/FirstHashElementIndentationshould allow a hash where the content of the first pair is indented relative to the base column specified with configured cop style, and the second pair begins on the same line with the right brace of the first pair; because those two keys won't be aligned with each other byLayout/HashAlignment, not like the case of #10689.With no parenthesis
With the parenthesis and
special_inside_parenthesesstyleWith the parenthesis and
consistentstyleBefore submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.