[Fix #10700] Update Style/EmptyMethod
to not correct if the correction would exceed the configuration for Layout/LineLength
#10742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an empty method definition is longer than the
Max
allowed byLayout/LineLength
, autocorrection ends up in an infinite loop:Layout/LineLength
splits the method onto two lines, and thenStyle/EmptyMethod
puts it back onto one line.This changes
Style/EmptyMethod
to not perform autocorrection withEnforcedStyle: compact
if the resulting change will exceed the allowed line length. An offense will still be registered but it will be up to the user to determine how to resolve it, which will prevent the infinite loop.NOTE: this makes an assumption that
Layout/LineLength
takes priority overStyle/EmptyMethod
for the purposes of correction.Fixes #10700.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.