[Fix #10734] Handle ClobberingError
in Style/NestedTernaryOperator
when there are multiple nested ternaries
#10739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style/NestedTernaryOperator
was doing corrections by replacing the entire if node with a rewritten form. However, when there are multiple ternaries nested inside a single if, this caused aClobberingError
as subsequent rewrites would change the same range.Instead, this takes a more surgical approach and edits by replacing the
?
and:
symbols and then wrapping the node withif
/end
. The result is the same syntax, but layout is no longer handled (but will be picked up by other cops).Fixes #10734.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.