Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10737] Fix crash in Style/ConditionalAssignment with EnforcedStyle: assign_inside_condition when op-assigning a variable inside a resbody #10738

Merged
merged 1 commit into from Jun 23, 2022

Conversation

dvandersluis
Copy link
Member

@dvandersluis dvandersluis commented Jun 22, 2022

Because this cop adds node handlers for all the assignment types, but an op-asgn node contains an lvasgn, the assignment_node method was crashing with:

undefined method `begin_type?' for :bar:Symbol

          assignment, = *assignment if assignment.begin_type? && assignment.children.one?
                                                 ^^^^^^^^^^^^

This change ignores assignments inside op-asgn, or_asgn and and_asgn nodes, as they will have already been covered by the relevant on_* method.

Fixes #10737.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…EnforcedStyle: assign_inside_condition` when op-assigning a variable inside a `resbody`.
@koic koic merged commit 08833f9 into rubocop:master Jun 23, 2022
@koic
Copy link
Member

koic commented Jun 23, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An error occurred while Style/ConditionalAssignment with EnforcedStyle: assign_inside_condition
2 participants