Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10719] Fix a false positive for Lint/ParenthesesAsGroupedExpression #10720

Conversation

koic
Copy link
Member

@koic koic commented Jun 17, 2022

Fixes #10719 and follow up #8039.

This PR fixes a false positive for Lint/ParenthesesAsGroupedExpression when using safe navigation operator.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…edExpression`

Fixes rubocop#10719 and follow up rubocop#8039.

This PR fixes a false positive for `Lint/ParenthesesAsGroupedExpression`
when using safe navigation operator.
@koic koic merged commit 3b49d85 into rubocop:master Jun 17, 2022
@koic koic deleted the fix_a_false_positive_for_lint_parentheses_as_grouped_expression branch June 17, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint/ParenthesesAsGroupedExpression with a space and a & auto-corrects to invalid code
1 participant