[Fix #10689] Fix autocorrect for Layout/FirstHashElementIndentation
and Layout/FirstArrayElementIndentation
#10707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10689
This PR fixes the autocorrect for
Layout/FirstHashElementIndentation
andLayout/FirstArrayElementIndentation
each combined withLayout/HashAlignment
.The new behavior indents the elements of a hash in a hash (or an array in a hash) based on the parent hash key when the parent hash is a method argument and has a following other sibling pair.
Example code to be corrected:
In the original behavior, the code is corrected like
With this fix, the code is corrected like
The autocorrect keeps the original behavior when the parent hash has no other following pairs. (I could change this so that the elements of the hash are always indented based on the parent hash key, but I kept the original behavior this time)
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.