[Fix #10693] Add ignore case for Style/EmptyLinesAroundAttributeAccessor when there is a comment line on the next line.
#10694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Jun 6, 2022
koic
reviewed
Jun 6, 2022
spec/rubocop/cop/layout/empty_lines_around_attribute_accessor_spec.rb
Outdated
Show resolved
Hide resolved
ydah
force-pushed
the
add_ignore_case_for_empty_lines_around_attribute_accessor
branch
2 times, most recently
from
73c20e5
to
8138885
Compare
koic
reviewed
Jun 7, 2022
spec/rubocop/cop/layout/empty_lines_around_attribute_accessor_spec.rb
Outdated
Show resolved
Hide resolved
ydah
force-pushed
the
add_ignore_case_for_empty_lines_around_attribute_accessor
branch
from
8138885
to
9a22ca6
Compare
koic
reviewed
Jun 7, 2022
| @@ -33,6 +33,129 @@ def do_something | |||
| RUBY | |||
| end | |||
|
|
|||
| it 'registers an offense and corrects for a attribute accessor and comment line' do | |||
There was a problem hiding this comment.
Suggested change
| it 'registers an offense and corrects for a attribute accessor and comment line' do | |
| it 'registers an offense and corrects for an attribute accessor and comment line' do |
…uteAccessor` when there is a comment line on the next line.
ydah
force-pushed
the
add_ignore_case_for_empty_lines_around_attribute_accessor
branch
from
9a22ca6
to
71076f5
Compare
|
Thanks! |
ydah
deleted the
add_ignore_case_for_empty_lines_around_attribute_accessor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve: #10693
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.