Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover Ruby 2.2 code analysis using TargetRubyVersion: 2.2 #10644

Merged
merged 1 commit into from
May 23, 2022

Commits on May 18, 2022

  1. Recover Ruby 2.2 code analysis using TargetRubyVersion: 2.2

    Follow up rubocop#10632 (comment).
    
    Reverts part of rubocop#6766, rubocop#7026, and rubocop#7030.
    
    Only the Ruby version (2.2) to runtime should have been dropped, not code analysis.
    This PR makes Ruby 2.2 code analysis with `TargetRubyVersion: 2.2`.
    It aims to solve essentially the same problem as rubocop#10626, rubocop#10632, and rubocop#10640.
    
    Previously, there was the following default enforced style `when_needed` for
    `Style/FrozenStringLiteralComment` cop.
    
    ```ruby
    # @example EnforcedStyle: when_needed (default)
    #   # The `when_needed` style will add the frozen string literal
    #   # to files only when the `TargetRubyVersion` is set to 2.3+.
    #   # bad
    #   module Foo
    #     # ...
    #   end
    #
    #   # good
    #   # frozen_string_literal: true
    #
    #   module Foo
    #     # ...
    #   end
    ```
    
    This PR does not restore that option, but sets the `minimum_target_ruby_version 2.3`
    to make `always (default)` apply by default. It is a simple solution that does not
    handle frozen literal magic comment added in Ruby 2.3 when `TargetRubyVersion` is
    Ruby 2.2 or lower.
    koic committed May 18, 2022
    Configuration menu
    Copy the full SHA
    a14ff0f View commit details
    Browse the repository at this point in the history