[Fix #10622] Fix a false positive for Style/RaiseArgs
#10623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_a_false_positive_for_style_raise_args
branch
from
ca2421e
to
2110edf
Compare
Fixes rubocop#10622. This PR fixes a false positive for `Style/RaiseArgs` when error type class constructor with keyword arguments and message argument. The signature of `raise` is below. ```ruby raise raise(string, cause: $!) raise(exception [, string [, array]], cause: $!) ``` https://ruby-doc.org/core-3.1.0/Kernel.html#method-i-raise So rubocop#10622 would be a false positive because `raise MyError.new(data: 'mydata'), 'message'` and `raise MyError.new('message', data: 'mydata')` are incompatible.
koic
force-pushed
the
fix_a_false_positive_for_style_raise_args
branch
from
2110edf
to
83cd538
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10622.
This PR fixes a false positive for
Style/RaiseArgswhen error type class constructor with keyword arguments and message argument.The signature of
raiseis below.https://ruby-doc.org/core-3.1.0/Kernel.html#method-i-raise
So #10622 would be a false positive because
raise MyError.new(data: 'mydata'), 'message'andraise MyError.new('message', data: 'mydata')are incompatible.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.