Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sorbet's typed sigil as a magic comment #10620

Merged
merged 1 commit into from
May 15, 2022
Merged

Add Sorbet's typed sigil as a magic comment #10620

merged 1 commit into from
May 15, 2022

Conversation

zachahn
Copy link
Contributor

@zachahn zachahn commented May 10, 2022

Hello! This PR adds Sorbet's typed sigil as a magic comment. I'm aware of the rubocop-sorbet project, but I thought this might belong here here because of the existing rules around magic comments.

I'm aware I didn't check all of the boxes below! I will come back and finish this up if you too believe this belongs here.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@bbatsov
Copy link
Collaborator

bbatsov commented May 13, 2022

Yeah, I think it's fine to teach RuboCop about it.

@zachahn zachahn marked this pull request as ready for review May 15, 2022 01:45
@bbatsov bbatsov merged commit 58c56bf into rubocop:master May 15, 2022
@bbatsov
Copy link
Collaborator

bbatsov commented May 15, 2022

Thanks!

@zachahn zachahn deleted the magic_comment_typed branch May 15, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants